[Vtigercrm-commits] [vtiger development] #7160: Invoice save reverts Sales Order to Approved

[vtiger development]

#7160: Invoice save reverts Sales Order to Approved
------------------------+---------------------------------------------------
 Reporter:  jcrisp      |       Owner:  developer 
     Type:  defect      |      Status:  new       
 Priority:  unassigned  |   Milestone:  Unassigned
Component:  vtigercrm   |     Version:  5.2.1     
 Keywords:              |  
------------------------+---------------------------------------------------
 This bug is related to :

 http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/6857

 http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/6786

 Whenever you save an Invoice, either by creating or editing, it sets the
 status of Sales Orders back to approved.

 This should not be allowed. If the user has chosen a status such then it
 should not be touched without further interaction.

 A quick fix is as follows :


 {{{

 Index: Invoice.php
 ===================================================================
 --- Invoice.php (revision 46)
 +++ Invoice.php (working copy)
 @@ -117,7 +117,7 @@
                 {
                         $so_id = $this->column_fields["salesorder_id"];
                         $query1 = "update vtiger_salesorder set
 sostatus='Approved' where salesorderid=?";
 -                       $this->db->pquery($query1, array($so_id));
 +//                     $this->db->pquery($query1, array($so_id));
                 }

                 //in ajax save we should not call this function, because
 this will delete all the existing product values

 }}}

 This just disables the line that writes the status.

 There may be a more elegant fix but IWFM

-- 
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/7160>
vtiger development <http://trac.vtiger.com/>
vtigerCRM