[Vtigercrm-commits] [vtiger development] #5449: vtlib: two fields of uitype=10 break reports

[vtiger development]

#5449: vtlib: two fields of uitype=10 break reports
-------------------------+--------------------------------------------------
  Reporter:  joebordes   |       Owner:  developer
      Type:  defect      |      Status:  reopened 
  Priority:  unassigned  |   Milestone:  5.1.1    
 Component:  vtigercrm   |     Version:  5.1.0-rc 
Resolution:              |    Keywords:           
-------------------------+--------------------------------------------------
Changes (by R.Cohen):

  * status:  closed => reopened
  * type:  Need More Info => defect
  * version:  5.1.0-wip => 5.1.0-rc
  * resolution:  wontfix =>
  * milestone:  5.1.0 => 5.1.1

Comment:

 This is still an issue in 5.1.0 rc

 Bug in code, CRMEntity.php function generateReportsQuery about line 1895:


 {{{
 if($adb->num_rows($ui10_modules_query)>0){
                                 $query.= " left join vtiger_crmentity as
 vtiger_crmentityRel$module$i on vtiger_crmentityRel$module.crmid =
 $tab_name.$column_name and vtiger_crmentityRel$module.deleted=0";
 for($j=0;$j<$adb->num_rows($ui10_modules_query);$j++){
                                         $rel_mod =
 $adb->query_result($ui10_modules_query,$j,'relmodule');
                                         $rel_obj =
 CRMEntity::getInstance($rel_mod);
                                         vtlib_setup_modulevars($rel_mod,
 $rel_obj);

                                                 $rel_tab_name =
 $rel_obj->table_name;
                                                 $rel_tab_index =
 $rel_obj->table_index;
                                         $query.= " left join $rel_tab_name
 as ".$rel_tab_name."Rel$module on
 ".$rel_tab_name."Rel$module.$rel_tab_index =
 vtiger_crmentityRel$module.crmid";
                                 }
 }}}

 The issue is with '''vtiger_crmentityRel$module''' which repeats.
 Appending the $i does the trick: '''vtiger_crmentityRel$module$i'''

-- 
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/5449#comment:4>
vtiger development <http://trac.vtiger.com/>
vtigerCRM