[Vtigercrm-commits] [vtiger development] #5400: Innecessary database access in multiple modules

vtiger development vtiger-tickets at trac.vtiger.com
Wed Nov 19 16:19:56 EST 2008


#5400: Innecessary database access in multiple modules
-----------------------+----------------------------------------------------
 Reporter:  elmue.gmx  |       Owner:  developer
     Type:  defect     |      Status:  new      
 Priority:  minor      |   Milestone:  5.1.0    
Component:  vtigercrm  |     Version:  5.0.4    
 Keywords:             |  
-----------------------+----------------------------------------------------
 Hello

 Serach all *.PHP files for the string "getComboArray"

 You will find a lot results.
 In approximately 15 files you find this code:

 $comboFieldArray = getComboArray($comboFieldNames);

 But the variable $comboFieldArray is never used in the file.

 This useless function call executes at least one SQL command each time it
 is called.

 So the database load can easily be reduced by deleting all these useless
 lines from all these archives.

 Can anybody with CVS access remove this nonsense stuff ?

 Elmü

-- 
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/5400>
vtiger development <http://trac.vtiger.com/>
vtigerCRM




More information about the vtigercrm-commits mailing list