[Vtigercrm-commits] [vtiger development] #5397: Some picklist values don't get translated

[vtiger development]

#5397: Some picklist values don't get translated
------------------------+---------------------------------------------------
  Reporter:  elmue.gmx  |       Owner:  developer
      Type:  defect     |      Status:  closed   
  Priority:  minor      |   Milestone:  5.1.0    
 Component:  vtigercrm  |     Version:  5.0.4    
Resolution:  fixed      |    Keywords:           
------------------------+---------------------------------------------------
Comment (by elmue.gmx):

 The same applies to EditViewUtils.php

 Additionally there is a SECOND bug in this file:
 It is nonsense to first apply to_html() and then htmlentities() on the
 same string!

 '''Wrong code:'''


 {{{
 $pickListValue = to_html($pickListValue);
 if(isset($_REQUEST['file']) && $_REQUEST['file'] == 'QuickCreate')
   $options[] =
 array(htmlentities(getTranslatedString($pickListValue),ENT_QUOTES,$default_charset),$pickListValue,$chk_val
 );
 else
   $options[] =
 array(getTranslatedString($pickListValue),$pickListValue,$chk_val );
 }}}



 '''Corrected code:'''


 {{{
 $translatedValue = getTranslatedString($pickListValue);
 if(isset($_REQUEST['file']) && $_REQUEST['file'] == 'QuickCreate')
    $options[] =
 array(htmlentities($translatedValue,ENT_QUOTES,$default_charset),to_html($pickListValue),$chk_val
 );
 else
   $options[] =
 array(to_html($translatedValue),to_html($pickListValue),$chk_val );
 }}}

-- 
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/5397#comment:2>
vtiger development <http://trac.vtiger.com/>
vtigerCRM