From vtiger-tickets at trac.vtiger.com Mon Nov 3 12:42:58 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Mon, 03 Nov 2008 20:42:58 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5392: Bug fixes for the migration script Message-ID: <042.62469df4db1d27492c59a5426fb90991@trac.vtiger.com> #5392: Bug fixes for the migration script ------------------------------+--------------------------------------------- Reporter: kristof | Owner: developer Type: patch | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.1.0-wip Keywords: migration bugfix | ------------------------------+--------------------------------------------- Hello, fixed several syntax error bugs in the migration script that were added recently. Patch attached. Kristof -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Tue Nov 4 00:30:50 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Tue, 04 Nov 2008 08:30:50 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5392: Bug fixes for the migration script In-Reply-To: <042.62469df4db1d27492c59a5426fb90991@trac.vtiger.com> References: <042.62469df4db1d27492c59a5426fb90991@trac.vtiger.com> Message-ID: <051.e4653f8b8c0ffa526e8f0e7f7f95de59@trac.vtiger.com> #5392: Bug fixes for the migration script ------------------------+--------------------------------------------------- Reporter: kristof | Owner: asha Type: patch | Status: assigned Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.1.0-wip Resolution: | Keywords: migration bugfix ------------------------+--------------------------------------------------- Changes (by asha): * status: new => assigned * owner: developer => asha -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Tue Nov 4 00:35:00 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Tue, 04 Nov 2008 08:35:00 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5392: Bug fixes for the migration script In-Reply-To: <042.62469df4db1d27492c59a5426fb90991@trac.vtiger.com> References: <042.62469df4db1d27492c59a5426fb90991@trac.vtiger.com> Message-ID: <051.beca27e645b1a6cee611f5bf15de71ab@trac.vtiger.com> #5392: Bug fixes for the migration script ------------------------+--------------------------------------------------- Reporter: kristof | Owner: asha Type: patch | Status: closed Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.1.0-wip Resolution: fixed | Keywords: migration bugfix ------------------------+--------------------------------------------------- Changes (by asha): * status: assigned => closed * resolution: => fixed Comment: Hi Kristof, Thanks for your contribution. We have integrated this fix. Please refer to the changeset: [http://trac.vtiger.com/cgi-bin/trac.cgi/changeset/12147/] -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Thu Nov 6 02:32:09 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Thu, 06 Nov 2008 10:32:09 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5393: we can not able to delete the default users, profiles and roles Message-ID: <041.b09c46fa8302b4d28f9696e1ce57c6f5@trac.vtiger.com> #5393: we can not able to delete the default users,profiles and roles -----------------------+---------------------------------------------------- Reporter: pratim | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | -----------------------+---------------------------------------------------- The default users(Standarduser) other than admin and the the default roles and profiles have no delete option -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Thu Nov 6 03:47:22 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Thu, 06 Nov 2008 11:47:22 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5393: we can not able to delete the default users, profiles and roles In-Reply-To: <041.b09c46fa8302b4d28f9696e1ce57c6f5@trac.vtiger.com> References: <041.b09c46fa8302b4d28f9696e1ce57c6f5@trac.vtiger.com> Message-ID: <050.0699aa21adac19765e37438d8175f34a@trac.vtiger.com> #5393: we can not able to delete the default users,profiles and roles ------------------------+--------------------------------------------------- Reporter: pratim | Owner: pratim Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: | Keywords: ------------------------+--------------------------------------------------- Changes (by asha): * owner: developer => pratim -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Fri Nov 7 02:08:34 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Fri, 07 Nov 2008 10:08:34 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5307: Campaign Related Getting Lost In-Reply-To: <041.7b1c204dd072d6275b2b7dbe83d890eb@trac.vtiger.com> References: <041.7b1c204dd072d6275b2b7dbe83d890eb@trac.vtiger.com> Message-ID: <050.54e389a6123cdeae5cae8b0eb362ac71@trac.vtiger.com> #5307: Campaign Related Getting Lost ------------------------+--------------------------------------------------- Reporter: prasad | Owner: developer Type: defect | Status: reopened Priority: major | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: | Keywords: ------------------------+--------------------------------------------------- Changes (by nitin): * status: closed => reopened * resolution: fixed => Comment: this part of the issue is still not fixed: if we are using load list option and If there were contacts with same last name only one of them will be stored -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Sun Nov 9 10:54:07 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Sun, 09 Nov 2008 18:54:07 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5394: Database foreign keys constraint not being created Message-ID: <044.d577f05467a0c28796a3b68a87b37bdc@trac.vtiger.com> #5394: Database foreign keys constraint not being created ------------------------+--------------------------------------------------- Reporter: joebordes | Owner: developer Type: defect | Status: new Priority: unassigned | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | ------------------------+--------------------------------------------------- Due to a parse or syntax error in the DatabaseSchema.xml file only the last foreign key constraint on each table is being created. See discussion here: http://forums.vtiger.com/viewtopic.php?p=72984 Joe TSolucio -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Mon Nov 10 02:52:35 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Mon, 10 Nov 2008 10:52:35 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5395: Qualifying an email to a contact is not attaching the file attched with the mail Message-ID: <041.8719195b7c09067c02817b476216b4d5@trac.vtiger.com> #5395: Qualifying an email to a contact is not attaching the file attched with the mail ------------------------+--------------------------------------------------- Reporter: pratim | Owner: developer Type: defect | Status: new Priority: unassigned | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | ------------------------+--------------------------------------------------- Steps to produce the issue 1-->configure your incoming mail server present in webmail. 2-->Send some mail to that mail id with some attchment. 3-->now go to webmail module there click on that mail and qualify it to contact. 4-->Now go to contact module go to the detail view of the newly created contact and go to the More information tag,here you can see only mail is the under add mail button,but no attachments. This thing was working fine in 503 but not working in 504. -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Mon Nov 10 02:58:51 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Mon, 10 Nov 2008 10:58:51 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5393: we can not able to delete the default users, profiles and roles In-Reply-To: <041.b09c46fa8302b4d28f9696e1ce57c6f5@trac.vtiger.com> References: <041.b09c46fa8302b4d28f9696e1ce57c6f5@trac.vtiger.com> Message-ID: <050.38347aea70e916b6a6c68fec327bfd84@trac.vtiger.com> #5393: we can not able to delete the default users,profiles and roles ------------------------+--------------------------------------------------- Reporter: pratim | Owner: pratim Type: defect | Status: closed Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: fixed | Keywords: ------------------------+--------------------------------------------------- Changes (by asha): * status: new => closed * resolution: => fixed Comment: This issue has been fixed and integrated. Please refer to the changeset [http://trac.vtiger.com/cgi-bin/trac.cgi/changeset/12166] -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Mon Nov 10 07:45:27 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Mon, 10 Nov 2008 15:45:27 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5372: vtiger CRM - LDAP Integration In-Reply-To: <041.2791d222440ee399543083cd115f6fc5@trac.vtiger.com> References: <041.2791d222440ee399543083cd115f6fc5@trac.vtiger.com> Message-ID: <050.436ab04b3a93812b28c1c4739ae5738f@trac.vtiger.com> #5372: vtiger CRM - LDAP Integration --------------------------+------------------------------------------------- Reporter: prasad | Owner: developer Type: enhancement | Status: closed Priority: unassigned | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by elmue.gmx): * status: new => closed * resolution: => fixed Comment: Hello Please note the the above mentioned thread is OUTDATED ! I created a new thread http://forums.vtiger.com/viewtopic.php?p=73028 where you can download version 3.0 of my LDAP patch which has a new interesting feature! Elm? -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 12 02:31:28 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 12 Nov 2008 10:31:28 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5396: include/database/PearDatabase.php limitQuery Bug Message-ID: <042.03152fc306a985bc24c199c0cd6cb990@trac.vtiger.com> #5396: include/database/PearDatabase.php limitQuery Bug ------------------------+--------------------------------------------------- Reporter: tapin13 | Owner: developer Type: defect | Status: new Priority: major | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: tags, utf8 | ------------------------+--------------------------------------------------- include/database/PearDatabase.php function limitQuery() There is no function to check UTF8. This function using for example in Tags, so, it tar not in english, there is error back from function. To repair it, you need to add standart elements to function. function limitQuery($sql,$start,$count, $dieOnError=false, $msg='') { global $log, '''$default_charset'''; //$this->println("ADODB limitQuery sql=".$sql." st=".$start." co=".$count); $log->debug(' limitQuery sql = '.$sql .' st = '.$start .' co = '.$count); $this->checkConnection(); '''if(strtoupper($default_charset) == 'UTF-8')''' '''$this->database->Execute("SET NAMES utf8");''' $result =& $this->database->SelectLimit($sql,$count,$start); -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 12 07:12:13 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 12 Nov 2008 15:12:13 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5397: Some picklist values don't get translated Message-ID: <044.a99e72d532b65bad71cbcfe90a262a0b@trac.vtiger.com> #5397: Some picklist values don't get translated -----------------------+---------------------------------------------------- Reporter: elmue.gmx | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | -----------------------+---------------------------------------------------- There is a bug in the code which results that the picklist value "Foods & Beverage" is not translated to other languages. The reason is that the translation function receives as input: "Foods & Beverage" The order of translation and conversion to HTML has to be reverse: File: DetailViewUtils.php Line: 163 '''Wrong code:''' $pickListValue = to_html($pickListValue); $options[] = array(getTranslatedString($pickListValue),$pickListValue,$chk_val ); '''Corrected code:''' $translatedValue = getTranslatedString($pickListValue); $options[] = array(to_html($translatedValue), to_html($pickListValue), $chk_val); Elm? -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 12 07:12:33 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 12 Nov 2008 15:12:33 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5397: Some picklist values don't get translated In-Reply-To: <044.a99e72d532b65bad71cbcfe90a262a0b@trac.vtiger.com> References: <044.a99e72d532b65bad71cbcfe90a262a0b@trac.vtiger.com> Message-ID: <053.ec1ef02ab8c4db7ff64567f71b34e647@trac.vtiger.com> #5397: Some picklist values don't get translated ------------------------+--------------------------------------------------- Reporter: elmue.gmx | Owner: developer Type: defect | Status: closed Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: fixed | Keywords: ------------------------+--------------------------------------------------- Changes (by elmue.gmx): * status: new => closed * resolution: => fixed -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 12 07:32:19 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 12 Nov 2008 15:32:19 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5397: Some picklist values don't get translated In-Reply-To: <044.a99e72d532b65bad71cbcfe90a262a0b@trac.vtiger.com> References: <044.a99e72d532b65bad71cbcfe90a262a0b@trac.vtiger.com> Message-ID: <053.867c4e8e0da82fc1161674c05bf13f42@trac.vtiger.com> #5397: Some picklist values don't get translated ------------------------+--------------------------------------------------- Reporter: elmue.gmx | Owner: developer Type: defect | Status: closed Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: fixed | Keywords: ------------------------+--------------------------------------------------- Comment (by elmue.gmx): The same applies to EditViewUtils.php Additionally there is a SECOND bug in this file: It is nonsense to first apply to_html() and then htmlentities() on the same string! '''Wrong code:''' {{{ $pickListValue = to_html($pickListValue); if(isset($_REQUEST['file']) && $_REQUEST['file'] == 'QuickCreate') $options[] = array(htmlentities(getTranslatedString($pickListValue),ENT_QUOTES,$default_charset),$pickListValue,$chk_val ); else $options[] = array(getTranslatedString($pickListValue),$pickListValue,$chk_val ); }}} '''Corrected code:''' {{{ $translatedValue = getTranslatedString($pickListValue); if(isset($_REQUEST['file']) && $_REQUEST['file'] == 'QuickCreate') $options[] = array(htmlentities($translatedValue,ENT_QUOTES,$default_charset),to_html($pickListValue),$chk_val ); else $options[] = array(to_html($translatedValue),to_html($pickListValue),$chk_val ); }}} -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 12 11:16:01 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 12 Nov 2008 19:16:01 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5398: Dotted display of huge currency values Message-ID: <044.cb9a5ae13f7f4128b23b145a07e5ae97@trac.vtiger.com> #5398: Dotted display of huge currency values -----------------------+---------------------------------------------------- Reporter: elmue.gmx | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | -----------------------+---------------------------------------------------- Big currency amounts are displayed in vtiger as 30000000 This is really ugly! You have to count the zeros to see if this is 300 millions or 30 millions. You can easily make a heavy error when entering big amounts without even noticing it. If you live in a country where big values are usual (e.g. where a television costs 1 million Pesos and a car costs 30 million Pesos) it is nearly impossible to work with vtiger! First: ======= This patch contains a bugfix which avoids that big currency values are displayed as 1E+6 in the Potentials Amount field instead of 1000000. Second: ======= This patch displays all currencies in the form "300.000.000". Currently vtiger is developed by programmers who do not know anything about REUSABLE code. The programmers of vtiger have a very ugly Copy and Paste mentality. Instead of writing ONE function which does ALL the formatting of currencies they repeat the code to format currencies by copy and paste in each module. An intelligent software design NEVER uses Copy and Paste to copy the same code to 10 places! I introduced a new function currencyDotFormat($amount) in the file CommonUtils.php which from now on does the formatting of currencies. This function is called from ALL places to format currency display. If you want your own, different way of formatting numbers you have to modify only this ONE function and vtiger will display your new number format in all places. Third: ====== When editing an amount value in the potentials you will notice that the textbox does not contain dots in the number. An amount of "300.000.000" will still be edited as "300000000". This is necessary to avoid Java Script errors and problems in other places. Only the DISPLAY of currency values is modified by my patch, not the other functionality like editing. For that it was necessary to introduce an additional value which is passed to the template DetailViewUI.tpl: keyval = 300000000 keydisplay = 300.000.000 See this thread for the download of the modified code and a screenshot: http://forums.vtiger.com/viewtopic.php?p=73159 Elm? -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Thu Nov 13 23:26:16 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Fri, 14 Nov 2008 07:26:16 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5399: Webpage has expired : IE issue Message-ID: <040.800144ee679935deb2d4bb13dca0b270@trac.vtiger.com> #5399: Webpage has expired : IE issue -----------------------+---------------------------------------------------- Reporter: nitin | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | -----------------------+---------------------------------------------------- Step to Reproduce: 1. Do a global search 2. Click on any of the search result 3. now click the back button of the browser to view search result, the Webpage has expired -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Fri Nov 14 02:44:00 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Fri, 14 Nov 2008 10:44:00 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5399: Webpage has expired : IE issue In-Reply-To: <040.800144ee679935deb2d4bb13dca0b270@trac.vtiger.com> References: <040.800144ee679935deb2d4bb13dca0b270@trac.vtiger.com> Message-ID: <049.6c358c99c785bb53dfce4f8360cf5bf7@trac.vtiger.com> #5399: Webpage has expired : IE issue ------------------------+--------------------------------------------------- Reporter: nitin | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: | Keywords: ------------------------+--------------------------------------------------- Comment (by nitin): change the form submit type for unifiedsearch in header.tpl to get from post -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 19 13:19:56 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 19 Nov 2008 21:19:56 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5400: Innecessary database access in multiple modules Message-ID: <044.c3b13bed796ee83ef94c195a112ea61b@trac.vtiger.com> #5400: Innecessary database access in multiple modules -----------------------+---------------------------------------------------- Reporter: elmue.gmx | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | -----------------------+---------------------------------------------------- Hello Serach all *.PHP files for the string "getComboArray" You will find a lot results. In approximately 15 files you find this code: $comboFieldArray = getComboArray($comboFieldNames); But the variable $comboFieldArray is never used in the file. This useless function call executes at least one SQL command each time it is called. So the database load can easily be reduced by deleting all these useless lines from all these archives. Can anybody with CVS access remove this nonsense stuff ? Elm? -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Fri Nov 21 07:15:12 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Fri, 21 Nov 2008 15:15:12 -0000 Subject: [Vtigercrm-commits] =?utf-8?q?=5Bvtiger_development=5D_=235401=3A?= =?utf-8?q?_Firefox_plugin_doesn=C2=B4t_work_in_firefox_3?= Message-ID: <053.e996702eb91f2eb2a4f5a7c52103ef87@trac.vtiger.com> #5401: Firefox plugin doesn?t work in firefox 3 ----------------------------------------+----------------------------------- Reporter: martin.mgscreativa | Owner: developer Type: defect | Status: new Priority: major | Milestone: 5.0.4 Component: vtigertoolbar | Version: 5.0.4 Keywords: plugin fiorefox extension | ----------------------------------------+----------------------------------- Hello, the plugin for fiorefox simply doesn?t work in Firefox 3 Be advised! -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Tue Nov 25 13:51:16 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Tue, 25 Nov 2008 21:51:16 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5340: Account names can't contain apostrophes In-Reply-To: <046.88e94464924e6923725ab4db5add28b3@trac.vtiger.com> References: <046.88e94464924e6923725ab4db5add28b3@trac.vtiger.com> Message-ID: <055.a3b5263479e4f9844a8d455f9fb0b3bf@trac.vtiger.com> #5340: Account names can't contain apostrophes --------------------------+------------------------------------------------- Reporter: Mike.Sasena | Owner: developer Type: patch | Status: closed Priority: unassigned | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: fixed | Keywords: apostrophe innerHTML --------------------------+------------------------------------------------- Changes (by densi): * keywords: => apostrophe innerHTML * status: new => closed * resolution: => fixed * type: defect => patch Comment: I found the solution 2 different problems: 1- all browsers (Firefox, IE7, opera 9, safari, chrome; all latest version) innerHTML corrupt the onclick="" javascript code in the javascript callSearch() in popup.tpl. A bug should be summitted to all. 2- include/utils/ListViewUtils.php decode_html function is checking the $_REQUEST variable. the code should look this: if($_REQUEST['action'] == 'Popup' || $_REQUEST['action'] == 'AccountsAjax') instead of: if($_REQUEST['action'] == 'Popup') This way, the apostrophe get formated like this: \' instead of like this: \' N.B. Maybe strrpos($_REQUEST['action'], 'Ajax') == 4 to filter ALL the module AJAX querks. I am sure at 60% that this code is better than the one above. BTW, really stupid to check $_REQUEST in decode_html(). -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Fri Nov 28 00:38:15 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Fri, 28 Nov 2008 08:38:15 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5402: Add PDF edition in Listview Message-ID: <043.94e842454726ed676c9e9b5c50fd2046@trac.vtiger.com> #5402: Add PDF edition in Listview ----------------------------------------------+----------------------------- Reporter: jf.mille | Owner: developer Type: enhancement | Status: new Priority: trivial | Milestone: 5.0.4 Component: vtigercrm | Version: 5.0.4 Keywords: Listview PDF Order Quote Invoice | ----------------------------------------------+----------------------------- By adding this script, you will be abble to generate PDF directly from Listview of Quotes, Sales Orders and Invoices. The link appears only if you have editing right to the document. -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Mon Nov 3 15:42:58 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Mon, 03 Nov 2008 20:42:58 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5392: Bug fixes for the migration script Message-ID: <042.62469df4db1d27492c59a5426fb90991@trac.vtiger.com> #5392: Bug fixes for the migration script ------------------------------+--------------------------------------------- Reporter: kristof | Owner: developer Type: patch | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.1.0-wip Keywords: migration bugfix | ------------------------------+--------------------------------------------- Hello, fixed several syntax error bugs in the migration script that were added recently. Patch attached. Kristof -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Tue Nov 4 03:30:50 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Tue, 04 Nov 2008 08:30:50 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5392: Bug fixes for the migration script In-Reply-To: <042.62469df4db1d27492c59a5426fb90991@trac.vtiger.com> References: <042.62469df4db1d27492c59a5426fb90991@trac.vtiger.com> Message-ID: <051.e4653f8b8c0ffa526e8f0e7f7f95de59@trac.vtiger.com> #5392: Bug fixes for the migration script ------------------------+--------------------------------------------------- Reporter: kristof | Owner: asha Type: patch | Status: assigned Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.1.0-wip Resolution: | Keywords: migration bugfix ------------------------+--------------------------------------------------- Changes (by asha): * status: new => assigned * owner: developer => asha -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Tue Nov 4 03:35:00 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Tue, 04 Nov 2008 08:35:00 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5392: Bug fixes for the migration script In-Reply-To: <042.62469df4db1d27492c59a5426fb90991@trac.vtiger.com> References: <042.62469df4db1d27492c59a5426fb90991@trac.vtiger.com> Message-ID: <051.beca27e645b1a6cee611f5bf15de71ab@trac.vtiger.com> #5392: Bug fixes for the migration script ------------------------+--------------------------------------------------- Reporter: kristof | Owner: asha Type: patch | Status: closed Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.1.0-wip Resolution: fixed | Keywords: migration bugfix ------------------------+--------------------------------------------------- Changes (by asha): * status: assigned => closed * resolution: => fixed Comment: Hi Kristof, Thanks for your contribution. We have integrated this fix. Please refer to the changeset: [http://trac.vtiger.com/cgi-bin/trac.cgi/changeset/12147/] -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Thu Nov 6 05:32:09 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Thu, 06 Nov 2008 10:32:09 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5393: we can not able to delete the default users, profiles and roles Message-ID: <041.b09c46fa8302b4d28f9696e1ce57c6f5@trac.vtiger.com> #5393: we can not able to delete the default users,profiles and roles -----------------------+---------------------------------------------------- Reporter: pratim | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | -----------------------+---------------------------------------------------- The default users(Standarduser) other than admin and the the default roles and profiles have no delete option -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Thu Nov 6 06:47:22 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Thu, 06 Nov 2008 11:47:22 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5393: we can not able to delete the default users, profiles and roles In-Reply-To: <041.b09c46fa8302b4d28f9696e1ce57c6f5@trac.vtiger.com> References: <041.b09c46fa8302b4d28f9696e1ce57c6f5@trac.vtiger.com> Message-ID: <050.0699aa21adac19765e37438d8175f34a@trac.vtiger.com> #5393: we can not able to delete the default users,profiles and roles ------------------------+--------------------------------------------------- Reporter: pratim | Owner: pratim Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: | Keywords: ------------------------+--------------------------------------------------- Changes (by asha): * owner: developer => pratim -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Fri Nov 7 05:08:34 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Fri, 07 Nov 2008 10:08:34 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5307: Campaign Related Getting Lost In-Reply-To: <041.7b1c204dd072d6275b2b7dbe83d890eb@trac.vtiger.com> References: <041.7b1c204dd072d6275b2b7dbe83d890eb@trac.vtiger.com> Message-ID: <050.54e389a6123cdeae5cae8b0eb362ac71@trac.vtiger.com> #5307: Campaign Related Getting Lost ------------------------+--------------------------------------------------- Reporter: prasad | Owner: developer Type: defect | Status: reopened Priority: major | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: | Keywords: ------------------------+--------------------------------------------------- Changes (by nitin): * status: closed => reopened * resolution: fixed => Comment: this part of the issue is still not fixed: if we are using load list option and If there were contacts with same last name only one of them will be stored -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Sun Nov 9 13:54:07 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Sun, 09 Nov 2008 18:54:07 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5394: Database foreign keys constraint not being created Message-ID: <044.d577f05467a0c28796a3b68a87b37bdc@trac.vtiger.com> #5394: Database foreign keys constraint not being created ------------------------+--------------------------------------------------- Reporter: joebordes | Owner: developer Type: defect | Status: new Priority: unassigned | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | ------------------------+--------------------------------------------------- Due to a parse or syntax error in the DatabaseSchema.xml file only the last foreign key constraint on each table is being created. See discussion here: http://forums.vtiger.com/viewtopic.php?p=72984 Joe TSolucio -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Mon Nov 10 05:52:35 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Mon, 10 Nov 2008 10:52:35 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5395: Qualifying an email to a contact is not attaching the file attched with the mail Message-ID: <041.8719195b7c09067c02817b476216b4d5@trac.vtiger.com> #5395: Qualifying an email to a contact is not attaching the file attched with the mail ------------------------+--------------------------------------------------- Reporter: pratim | Owner: developer Type: defect | Status: new Priority: unassigned | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | ------------------------+--------------------------------------------------- Steps to produce the issue 1-->configure your incoming mail server present in webmail. 2-->Send some mail to that mail id with some attchment. 3-->now go to webmail module there click on that mail and qualify it to contact. 4-->Now go to contact module go to the detail view of the newly created contact and go to the More information tag,here you can see only mail is the under add mail button,but no attachments. This thing was working fine in 503 but not working in 504. -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Mon Nov 10 05:58:51 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Mon, 10 Nov 2008 10:58:51 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5393: we can not able to delete the default users, profiles and roles In-Reply-To: <041.b09c46fa8302b4d28f9696e1ce57c6f5@trac.vtiger.com> References: <041.b09c46fa8302b4d28f9696e1ce57c6f5@trac.vtiger.com> Message-ID: <050.38347aea70e916b6a6c68fec327bfd84@trac.vtiger.com> #5393: we can not able to delete the default users,profiles and roles ------------------------+--------------------------------------------------- Reporter: pratim | Owner: pratim Type: defect | Status: closed Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: fixed | Keywords: ------------------------+--------------------------------------------------- Changes (by asha): * status: new => closed * resolution: => fixed Comment: This issue has been fixed and integrated. Please refer to the changeset [http://trac.vtiger.com/cgi-bin/trac.cgi/changeset/12166] -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Mon Nov 10 10:45:27 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Mon, 10 Nov 2008 15:45:27 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5372: vtiger CRM - LDAP Integration In-Reply-To: <041.2791d222440ee399543083cd115f6fc5@trac.vtiger.com> References: <041.2791d222440ee399543083cd115f6fc5@trac.vtiger.com> Message-ID: <050.436ab04b3a93812b28c1c4739ae5738f@trac.vtiger.com> #5372: vtiger CRM - LDAP Integration --------------------------+------------------------------------------------- Reporter: prasad | Owner: developer Type: enhancement | Status: closed Priority: unassigned | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by elmue.gmx): * status: new => closed * resolution: => fixed Comment: Hello Please note the the above mentioned thread is OUTDATED ! I created a new thread http://forums.vtiger.com/viewtopic.php?p=73028 where you can download version 3.0 of my LDAP patch which has a new interesting feature! Elm? -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 12 05:31:28 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 12 Nov 2008 10:31:28 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5396: include/database/PearDatabase.php limitQuery Bug Message-ID: <042.03152fc306a985bc24c199c0cd6cb990@trac.vtiger.com> #5396: include/database/PearDatabase.php limitQuery Bug ------------------------+--------------------------------------------------- Reporter: tapin13 | Owner: developer Type: defect | Status: new Priority: major | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: tags, utf8 | ------------------------+--------------------------------------------------- include/database/PearDatabase.php function limitQuery() There is no function to check UTF8. This function using for example in Tags, so, it tar not in english, there is error back from function. To repair it, you need to add standart elements to function. function limitQuery($sql,$start,$count, $dieOnError=false, $msg='') { global $log, '''$default_charset'''; //$this->println("ADODB limitQuery sql=".$sql." st=".$start." co=".$count); $log->debug(' limitQuery sql = '.$sql .' st = '.$start .' co = '.$count); $this->checkConnection(); '''if(strtoupper($default_charset) == 'UTF-8')''' '''$this->database->Execute("SET NAMES utf8");''' $result =& $this->database->SelectLimit($sql,$count,$start); -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 12 10:12:13 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 12 Nov 2008 15:12:13 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5397: Some picklist values don't get translated Message-ID: <044.a99e72d532b65bad71cbcfe90a262a0b@trac.vtiger.com> #5397: Some picklist values don't get translated -----------------------+---------------------------------------------------- Reporter: elmue.gmx | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | -----------------------+---------------------------------------------------- There is a bug in the code which results that the picklist value "Foods & Beverage" is not translated to other languages. The reason is that the translation function receives as input: "Foods & Beverage" The order of translation and conversion to HTML has to be reverse: File: DetailViewUtils.php Line: 163 '''Wrong code:''' $pickListValue = to_html($pickListValue); $options[] = array(getTranslatedString($pickListValue),$pickListValue,$chk_val ); '''Corrected code:''' $translatedValue = getTranslatedString($pickListValue); $options[] = array(to_html($translatedValue), to_html($pickListValue), $chk_val); Elm? -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 12 10:12:33 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 12 Nov 2008 15:12:33 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5397: Some picklist values don't get translated In-Reply-To: <044.a99e72d532b65bad71cbcfe90a262a0b@trac.vtiger.com> References: <044.a99e72d532b65bad71cbcfe90a262a0b@trac.vtiger.com> Message-ID: <053.ec1ef02ab8c4db7ff64567f71b34e647@trac.vtiger.com> #5397: Some picklist values don't get translated ------------------------+--------------------------------------------------- Reporter: elmue.gmx | Owner: developer Type: defect | Status: closed Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: fixed | Keywords: ------------------------+--------------------------------------------------- Changes (by elmue.gmx): * status: new => closed * resolution: => fixed -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 12 10:32:19 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 12 Nov 2008 15:32:19 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5397: Some picklist values don't get translated In-Reply-To: <044.a99e72d532b65bad71cbcfe90a262a0b@trac.vtiger.com> References: <044.a99e72d532b65bad71cbcfe90a262a0b@trac.vtiger.com> Message-ID: <053.867c4e8e0da82fc1161674c05bf13f42@trac.vtiger.com> #5397: Some picklist values don't get translated ------------------------+--------------------------------------------------- Reporter: elmue.gmx | Owner: developer Type: defect | Status: closed Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: fixed | Keywords: ------------------------+--------------------------------------------------- Comment (by elmue.gmx): The same applies to EditViewUtils.php Additionally there is a SECOND bug in this file: It is nonsense to first apply to_html() and then htmlentities() on the same string! '''Wrong code:''' {{{ $pickListValue = to_html($pickListValue); if(isset($_REQUEST['file']) && $_REQUEST['file'] == 'QuickCreate') $options[] = array(htmlentities(getTranslatedString($pickListValue),ENT_QUOTES,$default_charset),$pickListValue,$chk_val ); else $options[] = array(getTranslatedString($pickListValue),$pickListValue,$chk_val ); }}} '''Corrected code:''' {{{ $translatedValue = getTranslatedString($pickListValue); if(isset($_REQUEST['file']) && $_REQUEST['file'] == 'QuickCreate') $options[] = array(htmlentities($translatedValue,ENT_QUOTES,$default_charset),to_html($pickListValue),$chk_val ); else $options[] = array(to_html($translatedValue),to_html($pickListValue),$chk_val ); }}} -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 12 14:16:01 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 12 Nov 2008 19:16:01 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5398: Dotted display of huge currency values Message-ID: <044.cb9a5ae13f7f4128b23b145a07e5ae97@trac.vtiger.com> #5398: Dotted display of huge currency values -----------------------+---------------------------------------------------- Reporter: elmue.gmx | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | -----------------------+---------------------------------------------------- Big currency amounts are displayed in vtiger as 30000000 This is really ugly! You have to count the zeros to see if this is 300 millions or 30 millions. You can easily make a heavy error when entering big amounts without even noticing it. If you live in a country where big values are usual (e.g. where a television costs 1 million Pesos and a car costs 30 million Pesos) it is nearly impossible to work with vtiger! First: ======= This patch contains a bugfix which avoids that big currency values are displayed as 1E+6 in the Potentials Amount field instead of 1000000. Second: ======= This patch displays all currencies in the form "300.000.000". Currently vtiger is developed by programmers who do not know anything about REUSABLE code. The programmers of vtiger have a very ugly Copy and Paste mentality. Instead of writing ONE function which does ALL the formatting of currencies they repeat the code to format currencies by copy and paste in each module. An intelligent software design NEVER uses Copy and Paste to copy the same code to 10 places! I introduced a new function currencyDotFormat($amount) in the file CommonUtils.php which from now on does the formatting of currencies. This function is called from ALL places to format currency display. If you want your own, different way of formatting numbers you have to modify only this ONE function and vtiger will display your new number format in all places. Third: ====== When editing an amount value in the potentials you will notice that the textbox does not contain dots in the number. An amount of "300.000.000" will still be edited as "300000000". This is necessary to avoid Java Script errors and problems in other places. Only the DISPLAY of currency values is modified by my patch, not the other functionality like editing. For that it was necessary to introduce an additional value which is passed to the template DetailViewUI.tpl: keyval = 300000000 keydisplay = 300.000.000 See this thread for the download of the modified code and a screenshot: http://forums.vtiger.com/viewtopic.php?p=73159 Elm? -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Fri Nov 14 02:26:16 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Fri, 14 Nov 2008 07:26:16 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5399: Webpage has expired : IE issue Message-ID: <040.800144ee679935deb2d4bb13dca0b270@trac.vtiger.com> #5399: Webpage has expired : IE issue -----------------------+---------------------------------------------------- Reporter: nitin | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | -----------------------+---------------------------------------------------- Step to Reproduce: 1. Do a global search 2. Click on any of the search result 3. now click the back button of the browser to view search result, the Webpage has expired -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Fri Nov 14 05:44:00 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Fri, 14 Nov 2008 10:44:00 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5399: Webpage has expired : IE issue In-Reply-To: <040.800144ee679935deb2d4bb13dca0b270@trac.vtiger.com> References: <040.800144ee679935deb2d4bb13dca0b270@trac.vtiger.com> Message-ID: <049.6c358c99c785bb53dfce4f8360cf5bf7@trac.vtiger.com> #5399: Webpage has expired : IE issue ------------------------+--------------------------------------------------- Reporter: nitin | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: | Keywords: ------------------------+--------------------------------------------------- Comment (by nitin): change the form submit type for unifiedsearch in header.tpl to get from post -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Wed Nov 19 16:19:56 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Wed, 19 Nov 2008 21:19:56 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5400: Innecessary database access in multiple modules Message-ID: <044.c3b13bed796ee83ef94c195a112ea61b@trac.vtiger.com> #5400: Innecessary database access in multiple modules -----------------------+---------------------------------------------------- Reporter: elmue.gmx | Owner: developer Type: defect | Status: new Priority: minor | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Keywords: | -----------------------+---------------------------------------------------- Hello Serach all *.PHP files for the string "getComboArray" You will find a lot results. In approximately 15 files you find this code: $comboFieldArray = getComboArray($comboFieldNames); But the variable $comboFieldArray is never used in the file. This useless function call executes at least one SQL command each time it is called. So the database load can easily be reduced by deleting all these useless lines from all these archives. Can anybody with CVS access remove this nonsense stuff ? Elm? -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Fri Nov 21 10:15:12 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Fri, 21 Nov 2008 15:15:12 -0000 Subject: [Vtigercrm-commits] =?utf-8?q?=5Bvtiger_development=5D_=235401=3A?= =?utf-8?q?_Firefox_plugin_doesn=C2=B4t_work_in_firefox_3?= Message-ID: <053.e996702eb91f2eb2a4f5a7c52103ef87@trac.vtiger.com> #5401: Firefox plugin doesn?t work in firefox 3 ----------------------------------------+----------------------------------- Reporter: martin.mgscreativa | Owner: developer Type: defect | Status: new Priority: major | Milestone: 5.0.4 Component: vtigertoolbar | Version: 5.0.4 Keywords: plugin fiorefox extension | ----------------------------------------+----------------------------------- Hello, the plugin for fiorefox simply doesn?t work in Firefox 3 Be advised! -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Tue Nov 25 16:51:16 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Tue, 25 Nov 2008 21:51:16 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5340: Account names can't contain apostrophes In-Reply-To: <046.88e94464924e6923725ab4db5add28b3@trac.vtiger.com> References: <046.88e94464924e6923725ab4db5add28b3@trac.vtiger.com> Message-ID: <055.a3b5263479e4f9844a8d455f9fb0b3bf@trac.vtiger.com> #5340: Account names can't contain apostrophes --------------------------+------------------------------------------------- Reporter: Mike.Sasena | Owner: developer Type: patch | Status: closed Priority: unassigned | Milestone: 5.1.0 Component: vtigercrm | Version: 5.0.4 Resolution: fixed | Keywords: apostrophe innerHTML --------------------------+------------------------------------------------- Changes (by densi): * keywords: => apostrophe innerHTML * status: new => closed * resolution: => fixed * type: defect => patch Comment: I found the solution 2 different problems: 1- all browsers (Firefox, IE7, opera 9, safari, chrome; all latest version) innerHTML corrupt the onclick="" javascript code in the javascript callSearch() in popup.tpl. A bug should be summitted to all. 2- include/utils/ListViewUtils.php decode_html function is checking the $_REQUEST variable. the code should look this: if($_REQUEST['action'] == 'Popup' || $_REQUEST['action'] == 'AccountsAjax') instead of: if($_REQUEST['action'] == 'Popup') This way, the apostrophe get formated like this: \' instead of like this: \' N.B. Maybe strrpos($_REQUEST['action'], 'Ajax') == 4 to filter ALL the module AJAX querks. I am sure at 60% that this code is better than the one above. BTW, really stupid to check $_REQUEST in decode_html(). -- Ticket URL: vtiger development vtigerCRM From vtiger-tickets at trac.vtiger.com Fri Nov 28 03:38:15 2008 From: vtiger-tickets at trac.vtiger.com (vtiger development) Date: Fri, 28 Nov 2008 08:38:15 -0000 Subject: [Vtigercrm-commits] [vtiger development] #5402: Add PDF edition in Listview Message-ID: <043.94e842454726ed676c9e9b5c50fd2046@trac.vtiger.com> #5402: Add PDF edition in Listview ----------------------------------------------+----------------------------- Reporter: jf.mille | Owner: developer Type: enhancement | Status: new Priority: trivial | Milestone: 5.0.4 Component: vtigercrm | Version: 5.0.4 Keywords: Listview PDF Order Quote Invoice | ----------------------------------------------+----------------------------- By adding this script, you will be abble to generate PDF directly from Listview of Quotes, Sales Orders and Invoices. The link appears only if you have editing right to the document. -- Ticket URL: vtiger development vtigerCRM