[Vtigercrm-commits] [vtiger development] #4115: Reports : Start Date is lower than end date and it still says that start date should be lower than end date

[vtiger development]

#4115: Reports : Start Date is lower than end date and it still says that start
date should be lower than end date
-----------------------------+----------------------------------------------
  Reporter:  etienne.jodoin  |       Owner:  etienne.jodoin
      Type:  defect          |      Status:  new           
  Priority:  unassigned      |   Milestone:  5.0.4         
 Component:  vtigercrm       |     Version:  5.0.3         
Resolution:                  |    Keywords:                
-----------------------------+----------------------------------------------
Comment (by etienne.jodoin):

 Here are the corrections :

 File Smarty/templates/ReportRun.tpl around line 198 after :


 {{{
  if(!dateValidate("startdate","Start Date","D"))
                 return false

         if(!dateValidate("enddate","End Date","D"))
                 return false
 }}}

 Replace :


 {{{
  if(! compareDates(date1.value,'Start Date',date2.value,'End Date','LE'))
                 return false;
 }}}

 By :


 {{{
  if(!dateComparison("startdate",'Start Date',"enddate",'End Date','LE'))
                 return false;
 }}}

 File module/Reports/ReportRun.php, in function RunTimeFilter, after :


 {{{
 $selectedfields = explode(":",$filtercolumn);
                         if($selectedfields[0] ==
 "vtiger_crmentity".$this->primarymodule)
                                 $selectedfields[0] = "vtiger_crmentity";
                         if($filter == "custom")
                         {
                                 if($startdate != "" && $enddate != "")
                                 {



 }}}

 Replace :


 {{{
 $stdfilterlist[$filtercolumn] =
 $selectedfields[0].".".$selectedfields[1]." between '".$startdate."
 00:00:00' and '".$enddate." 23:59:00'";
 }}}

 By :


 {{{
 $stdfilterlist[$filtercolumn] =
 $selectedfields[0].".".$selectedfields[1]." between
 '".getDBInsertDateValue($startdate)." 00:00:00' and
 '".getDBInsertDateValue($enddate)." 23:59:00'";
 }}}

 File modules/Reports/Reports.js, in function changeSteps1, after :


 {{{
 if(!dateValidate("startdate","Start Date","D"))
                         return false

                 if(!dateValidate("enddate","End Date","D"))
                         return false
 }}}

 Replace :


 {{{
 if(! compareDates(date1.value,'Start Date',date2.value,'End Date','LE'))

 }}}

 By :


 {{{
 if(! dateComparison("startdate",'Start Date',"enddate",'End Date','LE'))
 }}}

-- 
Ticket URL: <http://trac.vtiger.com/cgi-bin/trac.cgi/ticket/4115#comment:2>
vtiger development <http://trac.vtiger.com/>
vtigerCRM