[Vtigercrm-commits] [vtiger-commits] r10809 - in /vtigercrm/branches/5.0.3: data/ install/ modules/Accounts/ modules/Campaigns/ modules/Contacts/ modules/Emails/ modules/Faq/ modules/HelpDesk/ modules/Invoice/ modules/Notes/ modules/Potentials/ modules/PriceBooks/ modules/PurchaseOrder/ modules/Quotes/ modules/SalesOrder/ modules/Users/ modules/Vendors/
vtigercrm-commits at vtiger.fosslabs.com
vtigercrm-commits at vtiger.fosslabs.com
Sat Apr 28 07:27:17 EDT 2007
Author: richie
Date: Sat Apr 28 05:26:45 2007
New Revision: 10809
Log:
patch for Call-time pass-by-reference has been deprecated integrated. Fixes #2486. --minnie
Modified:
vtigercrm/branches/5.0.3/data/CRMEntity.php
vtigercrm/branches/5.0.3/install/populateSeedData.php
vtigercrm/branches/5.0.3/modules/Accounts/Save.php
vtigercrm/branches/5.0.3/modules/Campaigns/Save.php
vtigercrm/branches/5.0.3/modules/Contacts/Save.php
vtigercrm/branches/5.0.3/modules/Emails/Save.php
vtigercrm/branches/5.0.3/modules/Emails/mail.php
vtigercrm/branches/5.0.3/modules/Faq/Save.php
vtigercrm/branches/5.0.3/modules/HelpDesk/DetailViewAjax.php
vtigercrm/branches/5.0.3/modules/HelpDesk/Save.php
vtigercrm/branches/5.0.3/modules/Invoice/Invoice.php
vtigercrm/branches/5.0.3/modules/Invoice/Save.php
vtigercrm/branches/5.0.3/modules/Notes/Save.php
vtigercrm/branches/5.0.3/modules/Potentials/Save.php
vtigercrm/branches/5.0.3/modules/PriceBooks/Save.php
vtigercrm/branches/5.0.3/modules/PurchaseOrder/PurchaseOrder.php
vtigercrm/branches/5.0.3/modules/PurchaseOrder/Save.php
vtigercrm/branches/5.0.3/modules/Quotes/Save.php
vtigercrm/branches/5.0.3/modules/SalesOrder/SalesOrder.php
vtigercrm/branches/5.0.3/modules/SalesOrder/Save.php
vtigercrm/branches/5.0.3/modules/Users/Save.php
vtigercrm/branches/5.0.3/modules/Users/Users.php
vtigercrm/branches/5.0.3/modules/Vendors/Save.php
Modified: vtigercrm/branches/5.0.3/data/CRMEntity.php
==============================================================================
--- vtigercrm/branches/5.0.3/data/CRMEntity.php (original)
+++ vtigercrm/branches/5.0.3/data/CRMEntity.php Sat Apr 28 05:26:45 2007
@@ -179,7 +179,7 @@
//only images are allowed for these modules
if($module == 'Contacts' || $module == 'Products')
{
- $save_file = validateImageFile(&$file_details);
+ $save_file = validateImageFile($file_details);
}
if($save_file == 'true' && $upload_status == 'true')
Modified: vtigercrm/branches/5.0.3/install/populateSeedData.php
==============================================================================
--- vtigercrm/branches/5.0.3/install/populateSeedData.php (original)
+++ vtigercrm/branches/5.0.3/install/populateSeedData.php Sat Apr 28 05:26:45 2007
@@ -477,6 +477,7 @@
$product->column_fields["productname"] = $product_name_array[$i];
$product->column_fields["productcode"] = $product_code_array[$i];
$product->column_fields["manufacturer"] = $manufacturer;
+ $product->column_fields["discontinued"] = 1;
$product->column_fields["productcategory"] = $category;
$product->column_fields["website"] = $website;
@@ -640,7 +641,7 @@
//Upto this added to set the request values which will be used to save the inventory product details
//Now call the saveInventoryProductDetails function
- saveInventoryProductDetails(&$quote, 'Quotes');
+ saveInventoryProductDetails($quote, 'Quotes');
}
//Populate SalesOrder Data
@@ -714,7 +715,7 @@
//Upto this added to set the request values which will be used to save the inventory product details
//Now call the saveInventoryProductDetails function
- saveInventoryProductDetails(&$so, 'SalesOrder');
+ saveInventoryProductDetails($so, 'SalesOrder');
}
@@ -790,7 +791,7 @@
//Upto this added to set the request values which will be used to save the inventory product details
//Now call the saveInventoryProductDetails function
- saveInventoryProductDetails(&$po, 'PurchaseOrder');
+ saveInventoryProductDetails($po, 'PurchaseOrder');
}
@@ -875,7 +876,7 @@
//Upto this added to set the request values which will be used to save the inventory product details
//Now call the saveInventoryProductDetails function
- saveInventoryProductDetails(&$invoice, 'Invoice');
+ saveInventoryProductDetails($invoice, 'Invoice');
}
Modified: vtigercrm/branches/5.0.3/modules/Accounts/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Accounts/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Accounts/Save.php Sat Apr 28 05:26:45 2007
@@ -126,7 +126,7 @@
//Send notification mail to the assigned to owner about the vtiger_account creation
if($focus->column_fields['notify_owner'] == 1 || $focus->column_fields['notify_owner'] == 'on')
- $status = sendNotificationToOwner('Accounts',&$focus);
+ $status = sendNotificationToOwner('Accounts',$focus);
header("Location: index.php?action=$return_action&module=$return_module&parenttab=$parenttab&record=$return_id&viewname=$return_viewname");
Modified: vtigercrm/branches/5.0.3/modules/Campaigns/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Campaigns/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Campaigns/Save.php Sat Apr 28 05:26:45 2007
@@ -30,7 +30,7 @@
$currencyid=fetchCurrency($current_user->id);
$rate_symbol = getCurrencySymbolandCRate($currencyid);
$rate = $rate_symbol['rate'];
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
if(isset($_REQUEST['expectedrevenue']))
{
Modified: vtigercrm/branches/5.0.3/modules/Contacts/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Contacts/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Contacts/Save.php Sat Apr 28 05:26:45 2007
@@ -30,7 +30,7 @@
global $log,$adb;
$focus = new Contacts();
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
if($_REQUEST['salutation'] == '--None--') $_REQUEST['salutation'] = '';
if (!isset($_REQUEST['email_opt_out'])) $focus->email_opt_out = 'off';
@@ -197,7 +197,7 @@
//Send notification mail to the assigned to owner about the contact creation
if($focus->column_fields['notify_owner'] == 1 || $focus->column_fields['notify_owner'] == 'on')
- $status = sendNotificationToOwner('Contacts',&$focus);
+ $status = sendNotificationToOwner('Contacts',$focus);
header("Location: index.php?action=$return_action&module=$return_module&parenttab=$parenttab&record=$return_id&activity_mode=$activitymode&viewname=$return_viewname");
Modified: vtigercrm/branches/5.0.3/modules/Emails/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Emails/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Emails/Save.php Sat Apr 28 05:26:45 2007
@@ -60,7 +60,7 @@
$focus = new Emails();
global $current_user,$mod_strings,$app_strings;
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
//Check if the file is exist or not.
//$file_name = '';
$file_name = $_FILES['filename']['name'];//preg_replace('/\s+/', '_', $_FILES['filename']['name']);
Modified: vtigercrm/branches/5.0.3/modules/Emails/mail.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Emails/mail.php (original)
+++ vtigercrm/branches/5.0.3/modules/Emails/mail.php Sat Apr 28 05:26:45 2007
@@ -46,15 +46,15 @@
$mail = new PHPMailer();
- setMailerProperties(&$mail,$subject,$contents,$from_email,$from_name,$to_email,$attachment,$emailid);
- setCCAddress(&$mail,'cc',$cc);
- setCCAddress(&$mail,'bcc',$bcc);
-
- $mail_status = MailSend(&$mail);
+ setMailerProperties($mail,$subject,$contents,$from_email,$from_name,$to_email,$attachment,$emailid);
+ setCCAddress($mail,'cc',$cc);
+ setCCAddress($mail,'bcc',$bcc);
+
+ $mail_status = MailSend($mail);
if($mail_status != 1)
{
- $mail_error = getMailError(&$mail,$mail_status,$mailto);
+ $mail_error = getMailError($mail,$mail_status,$mailto);
}
else
{
@@ -144,7 +144,7 @@
$mail->IsSMTP(); //set mailer to use SMTP
//$mail->Host = "smtp1.example.com;smtp2.example.com"; // specify main and backup server
- setMailServerProperties(&$mail);
+ setMailServerProperties($mail);
//Handle the from name and email for HelpDesk
$mail->From = $from_email;
@@ -174,13 +174,13 @@
//If we want to add the currently selected file only then we will use the following function
if($attachment == 'current')
{
- addAttachment(&$mail,$_FILES['filename']['name'],$emailid);
+ addAttachment($mail,$_FILES['filename']['name'],$emailid);
}
//This will add all the vtiger_files which are related to this record or email
if($attachment == 'all')
{
- addAllAttachments(&$mail,$emailid);
+ addAllAttachments($mail,$emailid);
}
$mail->IsHTML(true); // set email format to HTML
Modified: vtigercrm/branches/5.0.3/modules/Faq/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Faq/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Faq/Save.php Sat Apr 28 05:26:45 2007
@@ -29,7 +29,7 @@
$focus = new Faq();
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
$focus->save("Faq");
$return_id = $focus->id;
Modified: vtigercrm/branches/5.0.3/modules/HelpDesk/DetailViewAjax.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/HelpDesk/DetailViewAjax.php (original)
+++ vtigercrm/branches/5.0.3/modules/HelpDesk/DetailViewAjax.php Sat Apr 28 05:26:45 2007
@@ -41,7 +41,7 @@
$assigned_group_name = $_REQUEST['assigned_group_name'];
$assigntype = $_REQUEST['assigntype'];
- $fldvalue = $modObj->constructUpdateLog(&$modObj, $modObj->mode, $assigned_group_name, $assigntype);
+ $fldvalue = $modObj->constructUpdateLog($modObj, $modObj->mode, $assigned_group_name, $assigntype);
$fldvalue = from_html($adb->formatString('vtiger_troubletickets','update_log',$fldvalue),($modObj->mode == 'edit')?true:false);
$modObj->save("HelpDesk");
Modified: vtigercrm/branches/5.0.3/modules/HelpDesk/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/HelpDesk/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/HelpDesk/Save.php Sat Apr 28 05:26:45 2007
@@ -27,7 +27,7 @@
$focus = new HelpDesk();
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
global $adb,$mod_strings;
//Added to update the ticket history
//Before save we have to construct the update log.
@@ -37,7 +37,7 @@
$usr_qry = $adb->query("select * from vtiger_crmentity where crmid='".$focus->id."'");
$old_user_id = $adb->query_result($usr_qry,0,"smownerid");
}
-$fldvalue = $focus->constructUpdateLog(&$focus, $mode, $_REQUEST['assigned_group_name'], $_REQUEST['assigntype']);
+$fldvalue = $focus->constructUpdateLog($focus, $mode, $_REQUEST['assigned_group_name'], $_REQUEST['assigntype']);
$fldvalue = from_html($adb->formatString('vtiger_troubletickets','update_log',$fldvalue),($mode == 'edit')?true:false);
$focus->save("HelpDesk");
Modified: vtigercrm/branches/5.0.3/modules/Invoice/Invoice.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Invoice/Invoice.php (original)
+++ vtigercrm/branches/5.0.3/modules/Invoice/Invoice.php Sat Apr 28 05:26:45 2007
@@ -114,7 +114,7 @@
if($_REQUEST['action'] != 'InvoiceAjax' && $_REQUEST['ajxaction'] != 'DETAILVIEW')
{
//Based on the total Number of rows we will save the product relationship with this entity
- saveInventoryProductDetails(&$this, 'Invoice');
+ saveInventoryProductDetails($this, 'Invoice');
}
//Added For Custom Invoice Number
//Here we Incrementing the new InvoiceNumber
Modified: vtigercrm/branches/5.0.3/modules/Invoice/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Invoice/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Invoice/Save.php Sat Apr 28 05:26:45 2007
@@ -30,7 +30,7 @@
$focus = new Invoice();
global $current_user;
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
$focus->save("Invoice");
Modified: vtigercrm/branches/5.0.3/modules/Notes/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Notes/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Notes/Save.php Sat Apr 28 05:26:45 2007
@@ -29,7 +29,7 @@
$focus = new Notes();
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
//Check if the file is exist or not.
if($_FILES["filename"]["size"] == 0 && $_FILES["filename"]["name"] != '')
Modified: vtigercrm/branches/5.0.3/modules/Potentials/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Potentials/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Potentials/Save.php Sat Apr 28 05:26:45 2007
@@ -33,7 +33,7 @@
$rate = $rate_symbol['rate'];
$curr_symbol= $rate_symbol['symbol'];
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
if(isset($_REQUEST['amount']))
{
@@ -58,7 +58,7 @@
if($_REQUEST['return_viewname'] != '')$return_viewname=$_REQUEST['return_viewname'];
//Added to send mail to the vtiger_potential-owner about the Potential
-$status = sendNotificationToOwner('Potentials',&$focus);
+$status = sendNotificationToOwner('Potentials',$focus);
header("Location: index.php?action=$return_action&module=$return_module&parenttab=$parenttab&record=$return_id&pot_id=$pot_id&viewname=$return_viewname");
Modified: vtigercrm/branches/5.0.3/modules/PriceBooks/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/PriceBooks/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/PriceBooks/Save.php Sat Apr 28 05:26:45 2007
@@ -27,7 +27,7 @@
$focus = new PriceBooks();
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
$focus->save("PriceBooks");
$return_id = $focus->id;
Modified: vtigercrm/branches/5.0.3/modules/PurchaseOrder/PurchaseOrder.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/PurchaseOrder/PurchaseOrder.php (original)
+++ vtigercrm/branches/5.0.3/modules/PurchaseOrder/PurchaseOrder.php Sat Apr 28 05:26:45 2007
@@ -104,7 +104,7 @@
if($_REQUEST['action'] != 'PurchaseOrderAjax' && $_REQUEST['ajxaction'] != 'DETAILVIEW')
{
//Based on the total Number of rows we will save the product relationship with this entity
- saveInventoryProductDetails(&$this, 'PurchaseOrder', $this->update_prod_stock);
+ saveInventoryProductDetails($this, 'PurchaseOrder', $this->update_prod_stock);
}
}
Modified: vtigercrm/branches/5.0.3/modules/PurchaseOrder/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/PurchaseOrder/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/PurchaseOrder/Save.php Sat Apr 28 05:26:45 2007
@@ -29,7 +29,7 @@
$focus = new PurchaseOrder();
global $current_user;
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
//Added code for auto product stock updation on receiving goods
$focus->update_prod_stock='';
Modified: vtigercrm/branches/5.0.3/modules/Quotes/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Quotes/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Quotes/Save.php Sat Apr 28 05:26:45 2007
@@ -29,7 +29,7 @@
$local_log =& LoggerManager::getLogger('index');
$focus = new Quotes();
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
$focus->save("Quotes");
Modified: vtigercrm/branches/5.0.3/modules/SalesOrder/SalesOrder.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/SalesOrder/SalesOrder.php (original)
+++ vtigercrm/branches/5.0.3/modules/SalesOrder/SalesOrder.php Sat Apr 28 05:26:45 2007
@@ -123,7 +123,7 @@
if($_REQUEST['action'] != 'SalesOrderAjax' && $_REQUEST['ajxaction'] != 'DETAILVIEW')
{
//Based on the total Number of rows we will save the product relationship with this entity
- saveInventoryProductDetails(&$this, 'SalesOrder');
+ saveInventoryProductDetails($this, 'SalesOrder');
}
}
Modified: vtigercrm/branches/5.0.3/modules/SalesOrder/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/SalesOrder/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/SalesOrder/Save.php Sat Apr 28 05:26:45 2007
@@ -29,7 +29,7 @@
$local_log =& LoggerManager::getLogger('index');
$focus = new SalesOrder();
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
$focus->save("SalesOrder");
Modified: vtigercrm/branches/5.0.3/modules/Users/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Users/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Users/Save.php Sat Apr 28 05:26:45 2007
@@ -99,7 +99,7 @@
if (!isset($_POST['deleted'])) $_REQUEST["deleted"] = '0';
if (!isset($_POST['homeorder']) || $_POST['homeorder'] == "" ) $_REQUEST["homeorder"] = 'ILTI,QLTQ,ALVT,PLVT,CVLVT,HLT,OLV,GRT,OLTSO';
- setObjectValuesFromRequest(&$focus);
+ setObjectValuesFromRequest($focus);
$focus->saveentity("Users");
//$focus->imagename = $image_upload_array['imagename'];
$focus->saveHomeOrder($focus->id);
Modified: vtigercrm/branches/5.0.3/modules/Users/Users.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Users/Users.php (original)
+++ vtigercrm/branches/5.0.3/modules/Users/Users.php Sat Apr 28 05:26:45 2007
@@ -915,7 +915,7 @@
//only images are allowed for these modules
if($module == 'Users')
{
- $save_file = validateImageFile(&$file_details);
+ $save_file = validateImageFile($file_details);
}
if($save_file == 'true')
{
Modified: vtigercrm/branches/5.0.3/modules/Vendors/Save.php
==============================================================================
--- vtigercrm/branches/5.0.3/modules/Vendors/Save.php (original)
+++ vtigercrm/branches/5.0.3/modules/Vendors/Save.php Sat Apr 28 05:26:45 2007
@@ -26,7 +26,7 @@
require_once('include/database/PearDatabase.php');
$focus = new Vendors();
-setObjectValuesFromRequest(&$focus);
+setObjectValuesFromRequest($focus);
$focus->save("Vendors");
$return_id = $focus->id;
More information about the vtigercrm-commits
mailing list