[Vtigercrm-commits] [vtiger development] #1520: Hard Coded Pick List entrys again

[vtiger development]

#1520: Hard Coded Pick List entrys again
-----------------------+----------------------------------------------------
 Reporter:  gopal      |       Owner:  developer
     Type:  defect     |      Status:  new      
 Priority:  critical   |   Milestone:           
Component:  vtigercrm  |     Version:  5.0.0    
 Keywords:             |  
-----------------------+----------------------------------------------------
 Hi team,
 i refer to the following thread
 http://forums.vtiger.com/viewtopic.php?t=5620&highlight=pick+list+translation.
 My investigation shows that the problem is still the same in version 5.0.

 In my understanding this is a conceptual problem.
 You are able not only to translate the values of the pick lists, which
 would make it possible to implement the translation concept,
 but also to change the entrys completely. In that case the normal
 translation concept does not solve the problem at all.

 For example (like posted some times before):

 If you change and translate (into german) the pick list 'Status' under
 Meetings/Calls from (originally) 'Planned, Held, not Held' to
 'geplant, zugesagt(confirmed), abgehalten, nicht abgehalten' the following
 problem occurs:
 In the database the Status is saved as 'geplant' in the activity table in
 field eventstatus.
 That means that the hard coded query in for instance
 /modules/Accounts/Account.php
 Code:
 $query = "SELECT activity.*,seactivityrel.*,
 contactdetails.contactid,.....      ......,and (  activity.eventstatus is
 NULL ||  activity.eventstatus != 'Held')";
 will never work.

 So there are different ways to solve this.
 For all Solutions you first have to identify where the changeable pick
 list values are are used as hard coded strings.

 First solution is just to make it not possible to change the picklists
 where the english values are used in the sources by removing them from the
 settings module.
 The disadvantage is that the user have to live with partially translated
 software.

 Second Solution (preferred) is to make it not possible to delete one of
 the 'predefined' values in the picklist (which then have to be implemented
 whith translation concept) but to add
 some more which have to be handled also with labels (translation concept)
 defineable by the user (for multi language installations).

 Third Solution is to eliminate the hard coded parts and make these querys
 configurable by the users like the definition of views.

 Fourth (short time) Solution for me is to change the code to the german
 pick list values. Works for me but it's a hack and not my preferred
 method.

 Are there any plans to solve this problem in future releases?

 Hope someone from the team could clarify,

 Andreas

-- 
Ticket URL: <http://vtiger.fosslabs.com/cgi-bin/trac.cgi/ticket/1520>
vtiger development <http://vtiger.fosslabs.com/>
vtigerCRM